feat: implement mutate rows #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorbernstein2
approved these changes
Jun 6, 2023
Comment on lines
81
to
83
| core_exceptions.DeadlineExceeded, | ||
| core_exceptions.ServiceUnavailable, | ||
| _MutateRowsIncomplete, |
There was a problem hiding this comment.
nit. add a comment explaining the source of the errors
# RPC level errors
core_exceptions.DeadlineExceeded,
core_exceptions.ServiceUnavailable,
# Entry level errors
_MutateRowsIncomplete,
| async for result_list in result_generator: | ||
| for result in result_list.entries: | ||
| # convert sub-request index to global index | ||
| orig_idx = active_request_indices.pop(result.index) |
There was a problem hiding this comment.
nit. pop is doing extra work here. Why not just a lookup?
There was a problem hiding this comment.
When the exception is caught on line 181, we need to know which mutation entries were still pending at the time of the exception, and only add those to the retry queue. So active_request_indices needs to drop indices as they are finalized
Although looking again, I'll move the pop to the end of the block, since this could turn into a tricky bug if this function becomes more complex over time, and an exception ends up being raised in between this line and self._handle_entry_error
Comment on lines
179
to
180
| # add this exception to list for each mutation that wasn't | ||
| # already handled |
There was a problem hiding this comment.
and update remaining_indices
| if result.status.code == 0: | ||
| continue | ||
| else: | ||
| self._handle_entry_error(orig_idx, entry_error) |
There was a problem hiding this comment.
Please add a comment that this will update remaining_indices
daniel-sanche
added a commit
that referenced
this pull request
Feb 5, 2024
* feat: add new v3.0.0 API skeleton (#745) * feat: improve rows filters (#751) * feat: read rows query model class (#752) * feat: implement row and cell model classes (#753) * feat: add pooled grpc transport (#748) * feat: implement read_rows (#762) * feat: implement mutate rows (#769) * feat: literal value filter (#767) * feat: row_exists and read_row (#778) * feat: read_modify_write and check_and_mutate_row (#780) * feat: sharded read rows (#766) * feat: ping and warm with metadata (#810) * feat: mutate rows batching (#770) * chore: restructure module paths (#816) * feat: improve timeout structure (#819) * fix: api errors apply to all bulk mutations * chore: reduce public api surface (#820) * feat: improve error group tracebacks on < py11 (#825) * feat: optimize read_rows (#852) * chore: add user agent suffix (#842) * feat: optimize retries (#854) * feat: add test proxy (#836) * chore(tests): add conformance tests to CI for v3 (#870) * chore(tests): turn off fast fail for conformance tets (#882) * feat: add TABLE_DEFAULTS enum for table method arguments (#880) * fix: pass None for retry in gapic calls (#881) * feat: replace internal dictionaries with protos in gapic calls (#875) * chore: optimize gapic calls (#863) * feat: expose retryable error codes to users (#879) * chore: update api_core submodule (#897) * chore: merge main into experimental_v3 (#900) * chore: pin conformance tests to v0.0.2 (#903) * fix: bulk mutation eventual success (#909) --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements and tests mutate_row and bulk_mutate_rows rpc calls, along with associated models and helpers
These functions will both return nothing on success, but will raise an exception with details about the failed mutation or group of mutations on error, after retries are attempted.
Errors are exposed as an ExceptionGroup in Python3.11+, allowing users to easily digest a group of errors that are raised together, in this case for multiple mutations, with multiple retries per mutation. We use a backwards compatible implementation to expose similar functionality in Python3.10 and lower
Note that mutation batching will come in a separate PR, as it builds off of the functions added here
todo: